Allow string_list flags to be set via repeated flag uses#15943
Merged
sgowroji merged 2 commits intobazelbuild:release-5.3.0from Jul 22, 2022
Merged
Allow string_list flags to be set via repeated flag uses#15943sgowroji merged 2 commits intobazelbuild:release-5.3.0from
sgowroji merged 2 commits intobazelbuild:release-5.3.0from
Conversation
For all parts of Bazel other than option parsing, string build setting flags with `allow_multiple = True` should behave just like `string_list` settings, even though they are fundamentally of a different type. This requires a lot of special casing all over the code base and also causes confusing user-facing behavior when transitioning on such settings. This commit deprecates the `allow_multiple` named parameter of `config.string` and as a replacement introduces a new named parameter `repeatable` on `config.string_list`. Settings with the latter set to True behave exactly like `string` settings with `allow_multiple = True` with respect to command-line option parsing and exactly like ordinary `string_list` flags in all other situations. Fixes bazelbuild#13817 Closes bazelbuild#14911. PiperOrigin-RevId: 462146752 Change-Id: I91ddc4328a1b2244f4303fcda7b4228b182a5d56
ShreeM01
added
the
team-Configurability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For all parts of Bazel other than option parsing, string build setting
flags with
allow_multiple = Trueshould behave just likestring_listsettings, even though they are fundamentally of a different type. This
requires a lot of special casing all over the code base and also causes
confusing user-facing behavior when transitioning on such settings.
This commit deprecates the
allow_multiplenamed parameter ofconfig.stringand as a replacement introduces a new named parameterrepeatableonconfig.string_list. Settings with the latter set to Truebehave exactly like
stringsettings withallow_multiple = Truewithrespect to command-line option parsing and exactly like ordinary
string_listflags in all other situations.Fixes #13817
Closes #14911.
PiperOrigin-RevId: 462146752
Change-Id: I91ddc4328a1b2244f4303fcda7b4228b182a5d56