target pattern file: allow comments#15923
Merged
sgowroji merged 2 commits intobazelbuild:release-5.3.0from Jul 20, 2022
Merged
Conversation
`--target_pattern_file` could be a great tool assisting migration of a code base from one Bazel config to another. User could define a list of targets that can be built with the new configs and incrementally expand that list with each change that was introduced. Multiple users / teams could collaborate on such migration by adding / removing their targets into / from the pattern file. Having the ability to provide comments to annotate the targets in the pattern file with extra information during the migration process added a great value and context for build maintainers to track migration progress. Add support for Bash-style comments to the target-pattern file. Closes bazelbuild#15903. PiperOrigin-RevId: 461861131 Change-Id: I401f71fcf1e343c8689424979e4f48fb723fba9f
ShreeM01
added
the
team-OSS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--target_pattern_filecould be a great tool assisting migration of acode base from one Bazel config to another. User could define a list of
targets that can be built with the new configs and incrementally expand
that list with each change that was introduced. Multiple users / teams
could collaborate on such migration by adding / removing their targets
into / from the pattern file.
Having the ability to provide comments to annotate the targets in the
pattern file with extra information during the migration process added a
great value and context for build maintainers to track migration
progress.
Add support for Bash-style comments to the target-pattern file.
Closes #15903.
PiperOrigin-RevId: 461861131
Change-Id: I401f71fcf1e343c8689424979e4f48fb723fba9f