Cherry-pick proto_lang_toolchain Starlarkfication and proto_common module#15854
Merged
ckolli5 merged 26 commits intobazelbuild:release-5.3.0from Jul 14, 2022
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Externally visible changes:
proto_common_do_not_usemodule is exposed with implementation matching Bazel@HEADproto_lang_toolchainrule is extended withplugin_format_flag,progress_message,mnemonic,protocol_compilerattributesproto_lang_toolchainrules doesn't accept$(PLUGIN_OUT)placeholder (there are no uses on github)ProtoLangToolchainInfoare accessible in Starlark and the provider can be constructedctx.actions.runandctx.actions.run_shellacceptresource_setparameterOther invisible changes:
proto_lang_toolchainrule is replaced with Starlark implementationProtoLangToolchainInfois implemented in Starlarkproto_common,proto_lang_toolchainrules are imported.resource_setparameterWhat's not changed:
proto_library,*_proto_library.Cherry-picks for "Starlarkify proto_lang_toolchain rule":
ProtoCommon.checkPrivateStarlarkificationAllowlistand Starlark annotations inProtoInfoandProtoSource(mostly from 2a44dbd Implement proto_common.write_descriptor_set in Starlark.)Cherry-picks for "Implement proto_common":
proto_common.compileproto_libraryStarlarkificiation