Fix fail message construction in cc_shared_library#15708
Merged
ckolli5 merged 1 commit intobazelbuild:release-5.3.0from Jun 21, 2022
ckolli5:ck/fix-fail-message-construction
Merged
Fix fail message construction in cc_shared_library#15708ckolli5 merged 1 commit intobazelbuild:release-5.3.0from ckolli5:ck/fix-fail-message-construction
ckolli5 merged 1 commit intobazelbuild:release-5.3.0from
ckolli5:ck/fix-fail-message-construction
Conversation
Previously, if there were many unaccounted for libraries, this would simply fail with: ``` Error in join: 'string' is not iterable ``` Closes #14697. PiperOrigin-RevId: 440090957
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if there were many unaccounted for libraries, this would simply fail with:
Closes #14697.
PiperOrigin-RevId: 440090957