Use the proper main repo mapping where appropriate#15666
Closed
Wyverald wants to merge 4 commits intobazelbuild:masterfrom
Closed
Use the proper main repo mapping where appropriate#15666Wyverald wants to merge 4 commits intobazelbuild:masterfrom
Wyverald wants to merge 4 commits intobazelbuild:masterfrom
Conversation
Use the main repo mapping (instead of ALWAYS_FALLBACK) to a) process .bzl load labels in the WORKSPACE file, and b) to process any labels passed to repo rules in either the WORKSPACE file or WORKSPACE-loaded macros. This change only has a noticeable effect for when the workspace name (specified using the `workspace` directive in the WORKSPACE file) is used in labels as `@workspace_name//some:thing`. Before this change, such a label would actually point to `@workspace_name//some:thing`, which is a different target than `@//some:thing`, even though they're backed by the same source. This is because we insert an implicit `local_repository(name='workspace_name',path='.')` clause into the WORKSPACE file (see also bazelbuild#15657 for a similar issue when Bzlmod is enabled). This quirk can cause many subtle bugs, including toolchains being missing because `@workspace_name//:toolchain_type` and `@//:toolchain_type` are in fact distinct toolchain types!
meteorcloudy
approved these changes
Jun 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the main repo mapping (instead of ALWAYS_FALLBACK) to a) process .bzl load labels in the WORKSPACE file, and b) to process any labels passed to repo rules in either the WORKSPACE file or WORKSPACE-loaded macros.
This change only has a noticeable effect for when the workspace name (specified using the
workspacedirective in the WORKSPACE file) is used in labels as@workspace_name//some:thing. Before this change, such a label would actually point to@workspace_name//some:thing, which is a different target than@//some:thing, even though they're backed by the same source. This is because we insert an implicitlocal_repository(name='workspace_name',path='.')clause into the WORKSPACE file (see also #15657 for a similar issue when Bzlmod is enabled).This quirk can cause many subtle bugs, including toolchains being missing because
@workspace_name//:toolchain_typeand@//:toolchain_typeare in fact distinct toolchain types!