Correctly format non-ASCII paths, arguments, and env vars in aquery o… #15447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utput and remote execution protocol. For historical reasons, Bazel internally encodes non-ASCII in BUILD/bzl files by taking individual input bytes (assumed to be UTF-8) and storing them in a String as the corresponding Latin1 characters. This encoding must be undone whenever these strings escape to the outside world. Fixes #14381. Closes #15333. PiperOrigin-RevId: 445941013
coeuvre
added a commit
to coeuvre/bazel
that referenced
this pull request
May 10, 2022
…aquery output and remote execution protocol. (bazelbuild#15447)" This reverts commit 65c1a33.
coeuvre
added a commit
to coeuvre/bazel
that referenced
this pull request
May 10, 2022
…aquery output and remote execution protocol. (bazelbuild#15447)" This reverts commit 65c1a33.
ShreeM01
added
the
team-Remote-Exec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…utput and remote execution protocol.
For historical reasons, Bazel internally encodes non-ASCII in BUILD/bzl files by taking individual input bytes (assumed to be UTF-8) and storing them in a String as the corresponding Latin1 characters. This encoding must be undone whenever these strings escape to the outside world.
Fixes #14381.
Closes #15333.
PiperOrigin-RevId: 445941013