Set keywords on appropriate lifecycle events.#15440
Merged
ckolli5 merged 1 commit intobazelbuild:release-5.2.0from May 10, 2022
ckolli5:ck/set-keywords-on-lifecycle-events
Merged
Set keywords on appropriate lifecycle events.#15440ckolli5 merged 1 commit intobazelbuild:release-5.2.0from ckolli5:ck/set-keywords-on-lifecycle-events
ckolli5 merged 1 commit intobazelbuild:release-5.2.0from
ckolli5:ck/set-keywords-on-lifecycle-events
Conversation
The docs for the PublishLifecycleEventRequest say that the notification_keywords field should be set if the build event is InvocationAttemptStarted or BuildEnqueued. However, Bazel did not conform to this spec. Closes #14857. PiperOrigin-RevId: 442902471
meteorcloudy
pushed a commit
that referenced
this pull request
May 10, 2022
The docs for the PublishLifecycleEventRequest say that the notification_keywords field should be set if the build event is InvocationAttemptStarted or BuildEnqueued. However, Bazel did not conform to this spec. Closes #14857. PiperOrigin-RevId: 442902471 Co-authored-by: Benjamin Peterson <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs for the PublishLifecycleEventRequest say that the notification_keywords field should be set if the build event is InvocationAttemptStarted or BuildEnqueued. However, Bazel did not conform to this spec.
Closes #14857.
PiperOrigin-RevId: 442902471