Add incompatible flag to disable cfg="host" from Starlark #15436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Host transitions are problematic where the host and exec environment are different (e.g., with Remote Execution). This change adds an incompatible flag that fails analysis if Starlark rules use `cfg = "host"`. Migrating is pretty straigt forward (replace `host` with `exec`) and should be automatable by buildifier (although I haven't tried to do so). Closes #14383. PiperOrigin-RevId: 441253060
coeuvre
added a commit
to coeuvre/bazel
that referenced
this pull request
May 10, 2022
…zelbuild#15436)" This reverts commit ddbac4a.
coeuvre
added a commit
to coeuvre/bazel
that referenced
this pull request
May 10, 2022
…zelbuild#15436)" This reverts commit ddbac4a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Host transitions are problematic where the host and exec environment are
different (e.g., with Remote Execution). This change adds an incompatible
flag that fails analysis if Starlark rules use
cfg = "host".Migrating is pretty straigt forward (replace
hostwithexec) andshould be automatable by buildifier (although I haven't tried to do so).
Closes #14383.
PiperOrigin-RevId: 441253060