Document @ as allowed in a package name #15428
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emperically, this works, and some rulesets (e.g. `rules_nodejs`) explicitly create packages whose names contain `@` characters. We should document this reality (or forbid it, but that would be a massively breaking change to the ecosystem).
illicitonion
added a commit
to illicitonion/bazel-gazelle
that referenced
this pull request
May 9, 2022
See bazelbuild/bazel#15428 for context. tl;dr: Bazel actually allows this, and some common rulesets (e.g. `rules_nodejs`) rely heavily on it.
sgowroji
added
team-Documentation
Wyverald
approved these changes
May 11, 2022
Member
Wyverald
left a comment
Wyverald
left a comment
There was a problem hiding this comment.
Thanks! You can clearly see that @ is an allowed character in the code
Wyverald
added
awaiting-PR-merge
sgowroji
removed
the
awaiting-PR-merge
achew22
pushed a commit
to bazel-contrib/bazel-gazelle
that referenced
this pull request
May 13, 2022
See bazelbuild/bazel#15428 for context. tl;dr: Bazel actually allows this, and some common rulesets (e.g. `rules_nodejs`) rely heavily on it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empirically, this works, and some rulesets (e.g.
rules_nodejs)explicitly create packages whose names contain
@characters.We should document this reality (or forbid it, but that would be a
massively breaking change to the ecosystem).
Additional context: https://bazelbuild.slack.com/archives/CEZUUKQ6P/p1651850227929389?thread_ts=1651832164.144609&cid=CEZUUKQ6P