Collect coverage from cc_binary data deps of py_test#15298
Merged
ckolli5 merged 2 commits intobazelbuild:release-5.2.0from May 12, 2022
Merged
Collect coverage from cc_binary data deps of py_test#15298ckolli5 merged 2 commits intobazelbuild:release-5.2.0from
ckolli5 merged 2 commits intobazelbuild:release-5.2.0from
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this commit, if a py_test executed a cc_binary from its data
deps, coverage for this cc_binary would not be collected. This is fixed
by adding the implicit
$collect_cc_coverageattribute toBazelPyTestRule, similar to how this is already done for
BazelShTestRule.
Fixes #15098.
Closes #15097.
PiperOrigin-RevId: 442800790
Fixes #15291.