Skip to content

Fix ZipDecompressor windows 0x80 (file attribute normal)#15260

Closed
tomdegoede wants to merge 2 commits intobazelbuild:masterfrom
tomdegoede:fix-windows-zipfileattributenormal
Closed

Fix ZipDecompressor windows 0x80 (file attribute normal)#15260
tomdegoede wants to merge 2 commits intobazelbuild:masterfrom
tomdegoede:fix-windows-zipfileattributenormal

Conversation

@tomdegoede
Copy link
Copy Markdown
Contributor

Fixes #9236. On a rare occasion a zip file contains files with the 0x80 attribute.

From https://docs.microsoft.com/en-us/windows/win32/fileio/file-attribute-constants
A file that does not have other attributes set. This attribute is valid only when used alone.

@sgowroji sgowroji added the team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. label Apr 16, 2022
@sgowroji sgowroji requested a review from meteorcloudy April 16, 2022 16:03
Comment thread src/main/java/com/google/devtools/build/lib/bazel/repository/ZipDecompressor.java Outdated
@meteorcloudy meteorcloudy added the awaiting-user-response Awaiting a response from the author label Apr 19, 2022
@tomdegoede tomdegoede requested a review from meteorcloudy April 19, 2022 14:36
@bazel-io bazel-io closed this in aa2a1f3 Apr 19, 2022
Juh-Roch pushed a commit to Juh-Roch/bazel that referenced this pull request Jul 18, 2022
Fixes bazelbuild#9236. On a rare occasion a zip file contains files with the 0x80 attribute.

From https://docs.microsoft.com/en-us/windows/win32/fileio/file-attribute-constants
A file that does not have other attributes set. This attribute is valid only when used alone.

Closes bazelbuild#15260.

PiperOrigin-RevId: 442825326
(cherry picked from commit aa2a1f3)
ckolli5 added a commit that referenced this pull request Jul 19, 2022
Fixes #9236. On a rare occasion a zip file contains files with the 0x80 attribute.

From https://docs.microsoft.com/en-us/windows/win32/fileio/file-attribute-constants
A file that does not have other attributes set. This attribute is valid only when used alone.

Closes #15260.

PiperOrigin-RevId: 442825326
(cherry picked from commit aa2a1f3)

Co-authored-by: Tom de Goede <[email protected]>
Co-authored-by: Chenchu K <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-user-response Awaiting a response from the author team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

http_archive, unrecognized file mode for [Content_Types].xml: 0x80

3 participants