Store start/end timestamps of locally executed actions in the disk cache. #15256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjgq
force-pushed
the
test-result-disk-cache
branch
from
69396f9 to
87a700c
Compare
Member
|
Hello @tjgq, Could you please take care of the failure buildkite presubmit checks. Thanks! |
tjgq
force-pushed
the
test-result-disk-cache
branch
from
87a700c to
f86b174
Compare
coeuvre
approved these changes
Apr 19, 2022
This is necessary to ensure that the generate-xml.sh action associated with every test, which embeds the test runner wall time, doesn't execute again when run on a warm disk cache. This PR makes the following changes: 1. Add SpawnResult#getStartTime alongside existing #getWallTime and populate it in various SpawnRunner implementations. 2. Populate the ExecutedActionMetadata with the start/wall times for a locally executed spawn when storing it in the disk cache. 3. Populate the SpawnResult with the start/wall times for a spawn retrieved from the disk cache. 4. Add a regression test for the scenario described above. In order to avoid changes to the remote execution protocol, the start/end time are stored in the existing ActionResult.execution_metadata fields. Since there is some mismatch between this field and the metrics available in a SpawnResult, this might be revisited later. Fixes bazelbuild#14426.
tjgq
force-pushed
the
test-result-disk-cache
branch
from
f86b174 to
6220041
Compare
sgowroji
added
team-Remote-Exec
Contributor
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
|
@bazel-io fork 5.2.0 |
bazel-io
removed
the
potential release blocker
ckolli5
added a commit
that referenced
this pull request
May 9, 2022
…che. (#15439) This is necessary to ensure that the generate-xml.sh action associated with every test, which embeds the test runner wall time, doesn't execute again when run on a warm disk cache. This PR makes the following changes: 1. Add SpawnResult#getStartTime alongside existing #getWallTime and populate it in various SpawnRunner implementations. 2. Populate the ExecutedActionMetadata with the start/wall times for a locally executed spawn when storing it in the disk cache. 3. Populate the SpawnResult with the start/wall times for a spawn retrieved from the disk cache. 4. Add a regression test for the scenario described above. In order to avoid changes to the remote execution protocol, the start/end time are stored in the existing ActionResult.execution_metadata fields. Since there is some mismatch between this field and the metrics available in a SpawnResult, this might be revisited later. Fixes #14426. Closes #15256. PiperOrigin-RevId: 443052342 Co-authored-by: Tiago Quelhas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary to ensure that the generate-xml.sh action associated with
every test, which embeds the test runner wall time, doesn't execute again when
run on a warm disk cache.
This PR makes the following changes:
it in various SpawnRunner implementations.
locally executed spawn when storing it in the disk cache.
retrieved from the disk cache.
In order to avoid changes to the remote execution protocol, the start/end
time are stored in the existing ActionResult.execution_metadata fields.
Since there is some mismatch between this field and the metrics available
in a SpawnResult, this might be revisited later.
Fixes #14426.