Fix android armeabi-v7a constraint #15248
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith
force-pushed
the
ks/fix-android-armeabi-v7a-constraint
branch
4 times, most recently
from
adbc734 to
4cb7f0f
Compare
Previously this was arm instead of armv7. It seems that armv7 is the correct constraint for this case. Fixes bazelbuild#14982
keith
force-pushed
the
ks/fix-android-armeabi-v7a-constraint
branch
from
4cb7f0f to
a8680ca
Compare
Collaborator
|
Taking a look at this. This does seem like a promising fix for #14982, and is the PR I was recalling to @gregce (comment #14982 (comment)). The big question is to find out how this will work with our internal Android processes, I'm going to import this and run a lot of tests, I'll report back when that's done (it may be a few days). |
katre
reviewed
Apr 20, 2022
| "armeabi-v7a": ["@platforms//cpu:armv7"], | ||
| "armeabi-v7a": [ | ||
| "@platforms//cpu:armv7", | ||
| "@platforms//os:android", |
Collaborator
There was a problem hiding this comment.
This can't be right, shouldn't this be osx?
Member
Author
There was a problem hiding this comment.
Collaborator
There was a problem hiding this comment.
I see, thanks for explaining.
Collaborator
|
Ran the internal tests and, as I suspected, there's no impact. I'm going to work on getting this submitted in the next few days. |
Contributor
ckolli5
added a commit
that referenced
this pull request
May 10, 2022
Previously this was arm instead of armv7. It seems that armv7 is the correct constraint for this case. Fixes #14982 Closes #15248. PiperOrigin-RevId: 444250195 Co-authored-by: Keith Smiley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this was arm instead of armv7. It seems that armv7 is the
correct constraint for this case.
Fixes #14982