Collect coverage from cc_binary data deps of py_test #15097
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, if a py_test executed a cc_binary from its data deps, coverage for this cc_binary would not be collected. This is fixed by adding the implicit `$collect_cc_coverage` attribute to BazelPyTestRule, similar to how this is already done for BazelShTestRule.
Collaborator
Author
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
|
@bazel-io fork 5.2.0 |
bazel-io
removed
the
potential release blocker
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Apr 20, 2022
Before this commit, if a py_test executed a cc_binary from its data deps, coverage for this cc_binary would not be collected. This is fixed by adding the implicit `$collect_cc_coverage` attribute to BazelPyTestRule, similar to how this is already done for BazelShTestRule. Fixes bazelbuild#15098. Closes bazelbuild#15097. PiperOrigin-RevId: 442800790
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Apr 20, 2022
Before this commit, if a py_test executed a cc_binary from its data deps, coverage for this cc_binary would not be collected. This is fixed by adding the implicit `$collect_cc_coverage` attribute to BazelPyTestRule, similar to how this is already done for BazelShTestRule. Fixes bazelbuild#15098. Closes bazelbuild#15097. PiperOrigin-RevId: 442800790
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Apr 21, 2022
Before this commit, if a py_test executed a cc_binary from its data deps, coverage for this cc_binary would not be collected. This is fixed by adding the implicit `$collect_cc_coverage` attribute to BazelPyTestRule, similar to how this is already done for BazelShTestRule. Fixes bazelbuild#15098. Closes bazelbuild#15097. PiperOrigin-RevId: 442800790
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Apr 21, 2022
Before this commit, if a py_test executed a cc_binary from its data deps, coverage for this cc_binary would not be collected. This is fixed by adding the implicit `$collect_cc_coverage` attribute to BazelPyTestRule, similar to how this is already done for BazelShTestRule. Fixes bazelbuild#15098. Closes bazelbuild#15097. PiperOrigin-RevId: 442800790
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Apr 21, 2022
Before this commit, if a py_test executed a cc_binary from its data deps, coverage for this cc_binary would not be collected. This is fixed by adding the implicit `$collect_cc_coverage` attribute to BazelPyTestRule, similar to how this is already done for BazelShTestRule. Fixes bazelbuild#15098. Closes bazelbuild#15097. PiperOrigin-RevId: 442800790
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Apr 21, 2022
Before this commit, if a py_test executed a cc_binary from its data deps, coverage for this cc_binary would not be collected. This is fixed by adding the implicit `$collect_cc_coverage` attribute to BazelPyTestRule, similar to how this is already done for BazelShTestRule. Fixes bazelbuild#15098. Closes bazelbuild#15097. PiperOrigin-RevId: 442800790
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
May 10, 2022
Before this commit, if a py_test executed a cc_binary from its data deps, coverage for this cc_binary would not be collected. This is fixed by adding the implicit `$collect_cc_coverage` attribute to BazelPyTestRule, similar to how this is already done for BazelShTestRule. Fixes bazelbuild#15098. Closes bazelbuild#15097. PiperOrigin-RevId: 442800790
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
May 12, 2022
Before this commit, if a py_test executed a cc_binary from its data deps, coverage for this cc_binary would not be collected. This is fixed by adding the implicit `$collect_cc_coverage` attribute to BazelPyTestRule, similar to how this is already done for BazelShTestRule. Fixes bazelbuild#15098. Closes bazelbuild#15097. PiperOrigin-RevId: 442800790
ckolli5
added a commit
that referenced
this pull request
May 12, 2022
Before this commit, if a py_test executed a cc_binary from its data deps, coverage for this cc_binary would not be collected. This is fixed by adding the implicit `$collect_cc_coverage` attribute to BazelPyTestRule, similar to how this is already done for BazelShTestRule. Fixes #15098. Closes #15097. PiperOrigin-RevId: 442800790 Co-authored-by: Chenchu Kolli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, if a py_test executed a cc_binary from its data
deps, coverage for this cc_binary would not be collected. This is fixed
by adding the implicit
$collect_cc_coverageattribute toBazelPyTestRule, similar to how this is already done for
BazelShTestRule.
Fixes #15098.