[5.1] Remote: Fix crashes by InterruptedException when dynamic execution is…#15091
Merged
Wyverald merged 1 commit intobazelbuild:release-5.1.0from Mar 21, 2022
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… enabled.
Fixes #14433.
The root cause is, inside
RemoteExecutionCache, the result ofFindMissingDigestsis shared with other threads without considering error handling. For example, if there are two or more threads uploading the same input and one thread got interrupted when waiting for the result ofFindMissingDigestscall, the call is cancelled and others threads still waiting for the upload will receive upload error due to the cancellation which is wrong.This PR fixes this by effectively applying reference count to the result of
FindMissingDigestscall so that if one thread got interrupted, as long as there are other threads depending on the result, the call won't be cancelled and the upload can continue.Closes #15001.
PiperOrigin-RevId: 436180205
Closes #14709.