Remote: Don't check TreeArtifact output #15077
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgowroji
added
the
team-Remote-Exec
meisterT
approved these changes
Mar 21, 2022
Contributor
|
@bazel-io fork 5.1 |
brentleyjones
pushed a commit
to brentleyjones/bazel
that referenced
this pull request
Mar 21, 2022
With a151116, we ignore action cache entry when checking the remote cache if a mandatory output of the Spawn is missing. However, this breaks Spawns that declare a directory output but don't generate anything under it. Since remote servers typically don't create directory ahead of time, and if the action itself doesn't create files under the directory, that directory will be eliminated from the action cache entry. This PR fixes that by not checking TreeArtifact output. Closes bazelbuild#15077. PiperOrigin-RevId: 436163970 (cherry picked from commit f585783)
Wyverald
pushed a commit
that referenced
this pull request
Mar 21, 2022
With a151116, we ignore action cache entry when checking the remote cache if a mandatory output of the Spawn is missing. However, this breaks Spawns that declare a directory output but don't generate anything under it. Since remote servers typically don't create directory ahead of time, and if the action itself doesn't create files under the directory, that directory will be eliminated from the action cache entry. This PR fixes that by not checking TreeArtifact output. Closes #15077. PiperOrigin-RevId: 436163970 (cherry picked from commit f585783) Co-authored-by: Chi Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a151116, we ignore action cache entry when checking the remote cache if a mandatory output of the Spawn is missing.
However, this breaks Spawns that declare a directory output but don't generate anything under it. Since remote servers typically don't create directory ahead of time, and if the action itself doesn't create files under the directory, that directory will be eliminated from the action cache entry.
This PR fixes that by not checking TreeArtifact output.
Fixes #15074.