Skip to content

remote: Proactively close the ZstdInputStream in ZstdDecompressingOutputStream.#15061

Closed
benjaminp wants to merge 1 commit intobazelbuild:masterfrom
benjaminp:remote-close
Closed

remote: Proactively close the ZstdInputStream in ZstdDecompressingOutputStream.#15061
benjaminp wants to merge 1 commit intobazelbuild:masterfrom
benjaminp:remote-close

Conversation

@benjaminp
Copy link
Copy Markdown
Collaborator

ZstdInputStream hangs onto some native memory, which should be released as soon as ZstdDecompressingOutputStream is done being used rather than when the finalizer runs.

@benjaminp benjaminp requested a review from a team as a code owner March 17, 2022 02:31
@benjaminp benjaminp force-pushed the remote-close branch 10 times, most recently from 4be55d2 to 1728fa6 Compare March 17, 2022 05:32
…putStream.

ZstdInputStream hangs onto some native memory, which should be released as soon as ZstdDecompressingOutputStream is done being used rather than when the finalizer runs.
@sgowroji sgowroji added the team-Remote-Exec Issues and PRs for the Execution (Remote) team label Mar 17, 2022
Copy link
Copy Markdown
Member

@coeuvre coeuvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bazel-io bazel-io closed this in 299022c Mar 31, 2022
@brentleyjones
Copy link
Copy Markdown
Contributor

@bazel-io fork 5.2

@benjaminp benjaminp deleted the remote-close branch April 5, 2022 05:02
ckolli5 added a commit that referenced this pull request May 2, 2022
…putStream. (#15372)

ZstdInputStream hangs onto some native memory, which should be released as soon as ZstdDecompressingOutputStream is done being used rather than when the finalizer runs.

Closes #15061.

PiperOrigin-RevId: 438521302

Co-authored-by: Benjamin Peterson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-Remote-Exec Issues and PRs for the Execution (Remote) team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants