[5.1] Adding Starlark dependencies to the package //external#14991
Merged
Wyverald merged 2 commits intobazelbuild:release-5.1.0from Mar 8, 2022
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative approach to fix #14280. It adds transitive closure of Starlark dependencies to
//externalpackage when loadingWORKSPACEfile, so it can be processed in the same way asBUILDfiles during query execution. Comparing to the approach taken in #14497, this approach is less intrusive, but not able to distinguish the extension files needed by//external:fooand//external:bar, meaningbuildfiles(//external:foo)returns the same result asbuildfiles(//external:*). However, this behavior is consistent with other packages. For example,buildfiles(//foo:bar)has the same result asbuildfiles(//foo:*).(cherry picked from commit a6c3f23)