Configure Apple crosstool to return a complete target triple that includes minimum OS version and target environment#14898
Closed
thii wants to merge 1 commit intobazelbuild:masterfrom
Conversation
includes minimum OS version and target environment This is required for bazelbuild/rules_swift#768
keith
reviewed
Feb 24, 2022
thii
commented
Feb 24, 2022
keith
approved these changes
Feb 24, 2022
Member
keith
left a comment
keith
left a comment
There was a problem hiding this comment.
this matches what xcode does today
Member
|
cc @oquenchil can you review? |
oquenchil
added
platform: apple
team-Rules-ObjC
Member
Author
|
@googlewalt Can you review? |
googlewalt
reviewed
Mar 24, 2022
googlewalt
approved these changes
Mar 24, 2022
Contributor
|
@bazel-io fork 5.2 |
thii
deleted the
configure-apple-crosstool-to-return-a-complete-target-triple-that
branch
thii
added a commit
to thii/bazel
that referenced
this pull request
Apr 15, 2022
…ludes minimum OS version and target environment This is required for bazelbuild/rules_swift#768 Closes bazelbuild#14898. PiperOrigin-RevId: 437770046 (cherry picked from commit 3442179)
thii
added a commit
to thii/bazel
that referenced
this pull request
Apr 18, 2022
…ludes minimum OS version and target environment This is required for bazelbuild/rules_swift#768 Closes bazelbuild#14898. PiperOrigin-RevId: 437770046 (cherry picked from commit 3442179)
ckolli5
pushed a commit
that referenced
this pull request
May 9, 2022
…ludes minimum OS version and target environment (#15266) This is required for bazelbuild/rules_swift#768 Closes #14898. PiperOrigin-RevId: 437770046 (cherry picked from commit 3442179)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required for bazelbuild/rules_swift#768