Set keywords on appropriate lifecycle events.#14857
Closed
benjaminp wants to merge 1 commit intobazelbuild:masterfrom
Closed
Set keywords on appropriate lifecycle events.#14857benjaminp wants to merge 1 commit intobazelbuild:masterfrom
benjaminp wants to merge 1 commit intobazelbuild:masterfrom
Conversation
benjaminp
changed the title
Contributor
Contributor
|
@michaeledgar could you please take a look? |
lfpino
approved these changes
Feb 22, 2022
gregestren
added
the
team-Core
Contributor
meisterT
reviewed
Mar 23, 2022
| case BUILD_ENQUEUED: | ||
| case INVOCATION_ATTEMPT_STARTED: | ||
| builder.addAllNotificationKeywords(getKeywords()); | ||
| break; |
Member
There was a problem hiding this comment.
please add an explicit default: // fall through here
Collaborator
Author
There was a problem hiding this comment.
Done, though I assumed a break; would be preferred over a fall-through comment.
The docs for the PublishLifecycleEventRequest say that the notification_keywords field should be set if the build event is InvocationAttemptStarted or BuildEnqueued. However, Bazel did not conform to this spec.
benjaminp
force-pushed
the
lifecycle-notification-keywords
branch
from
9d7ff28 to
b05653b
Compare
Contributor
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
|
@bazel-io fork 5.2.0 |
bazel-io
removed
the
potential release blocker
ckolli5
added a commit
that referenced
this pull request
May 10, 2022
The docs for the PublishLifecycleEventRequest say that the notification_keywords field should be set if the build event is InvocationAttemptStarted or BuildEnqueued. However, Bazel did not conform to this spec. Closes #14857. PiperOrigin-RevId: 442902471 Co-authored-by: Benjamin Peterson <[email protected]>
meteorcloudy
pushed a commit
that referenced
this pull request
May 10, 2022
The docs for the PublishLifecycleEventRequest say that the notification_keywords field should be set if the build event is InvocationAttemptStarted or BuildEnqueued. However, Bazel did not conform to this spec. Closes #14857. PiperOrigin-RevId: 442902471 Co-authored-by: Benjamin Peterson <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs for the PublishLifecycleEventRequest say that the notification_keywords field should be set if the build event is InvocationAttemptStarted or BuildEnqueued. However, Bazel did not conform to this spec.