Add removeprefix/removesuffix to Starlark strings #14824
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 15, 2022
Collaborator
Author
|
This is ready for review now that bazelbuild/starlark@d6a52c5 has landed. |
adonovan
reviewed
Feb 15, 2022
Collaborator
Author
|
@adonovan I added a failure test and a test for no modifications for each method now that this behavior is also documented in the spec. |
laurentlb
approved these changes
Feb 18, 2022
Contributor
laurentlb
left a comment
laurentlb
left a comment
There was a problem hiding this comment.
lgtm
(I've started the import process, but it's waiting for approval inside Google)
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Feb 24, 2022
Implements bazelbuild/starlark#185 in Java Starlark. Closes bazelbuild#14824. PiperOrigin-RevId: 430556229
Wyverald
pushed a commit
that referenced
this pull request
Feb 24, 2022
Implements bazelbuild/starlark#185 in Java Starlark. Closes #14824. PiperOrigin-RevId: 430556229
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements bazelbuild/starlark#185 in Java Starlark.