Add a helper method for rules to depend on the cpp toolchain type. #14742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katre
changed the title
Collaborator
Author
|
Does the idea behind this make sense? Will this make migrations to use optional toolchains easier, or will it just add an extra precondition because users want to support pre-5.1 versions of Bazel? |
comius
approved these changes
Feb 10, 2022
Contributor
It will make it possible to be forward compatible, but only once a ruleset only supports Bazel 5.1+. That's better than nothing imo. |
fmeum
pushed a commit
to fmeum/bazel
that referenced
this pull request
Feb 11, 2022
Fixes bazelbuild#14728, part of bazelbuild#14727. Rules can begin using this as soon as it is released (hopefully in Bazel 5.1), and then future versions of Bazel will update the functionality as optional toolchains are added and C++ rules are updated to use them. Closes bazelbuild#14742. PiperOrigin-RevId: 427931123
Collaborator
|
I created #14795 to get this cherry-picked into 5.1.0. |
Collaborator
Author
|
Thank you! |
Wyverald
pushed a commit
that referenced
this pull request
Feb 14, 2022
…14795) Fixes #14728, part of #14727. Rules can begin using this as soon as it is released (hopefully in Bazel 5.1), and then future versions of Bazel will update the functionality as optional toolchains are added and C++ rules are updated to use them. Closes #14742. PiperOrigin-RevId: 427931123 Co-authored-by: John Cater <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14728, part of #14727.
Rules can begin using this as soon as it is released (hopefully in Bazel
5.1), and then future versions of Bazel will update the functionality as
optional toolchains are added and C++ rules are updated to use them.