Expose CoverageOutputGenerator on a Fragment#14724
Closed
fmeum wants to merge 1 commit intobazelbuild:masterfrom
Closed
Expose CoverageOutputGenerator on a Fragment#14724fmeum wants to merge 1 commit intobazelbuild:masterfrom
fmeum wants to merge 1 commit intobazelbuild:masterfrom
Conversation
Collaborator
Author
This was referenced Feb 27, 2022
Member
|
@c-mita can you review? |
c-mita
reviewed
Mar 2, 2022
Member
c-mita
left a comment
c-mita
left a comment
There was a problem hiding this comment.
LGTM, maybe add a comment on the output_generator doc indicating it may be None, since I don't think that's obvious behaviour.
| allowReturnNones = true, | ||
| structField = true, | ||
| doc = | ||
| "Returns label pointed to by " |
Member
There was a problem hiding this comment.
Can you add a note saying that this will be None if coverage collection isn't enabled?
Collaborator
Author
There was a problem hiding this comment.
Done, I also slightly reworded the comment.
Member
|
Ideally, I'd prefer this was guarded by an experimental flag, but I don't think that's feasible without making the feature clunky to use, so I'll let that pass. |
This allows Starlark rules to define _lcov_merger as a late-bound Starlark configuration_field in order not to pay the cost of building it when coverage isn't enabled.
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Mar 8, 2022
This allows Starlark rules to define _lcov_merger as a late-bound Starlark configuration_field in order not to pay the cost of building it when coverage isn't enabled. Fixes bazelbuild#8736 Fixes bazelbuild#10642 Closes bazelbuild#14724. RELNOTES: Add coverage configuration fragment, used to expose output_generator label. PiperOrigin-RevId: 433156089
Wyverald
pushed a commit
that referenced
this pull request
Mar 8, 2022
This allows Starlark rules to define _lcov_merger as a late-bound Starlark configuration_field in order not to pay the cost of building it when coverage isn't enabled. Fixes #8736 Fixes #10642 Closes #14724. RELNOTES: Add coverage configuration fragment, used to expose output_generator label. PiperOrigin-RevId: 433156089
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows Starlark rules to define _lcov_merger as a late-bound Starlark configuration_field in order not to pay the cost of building it when coverage isn't enabled.
Fixes #8736
Fixes #10642