Improve documentation for select() #14458
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
fmeum
commented
Dec 21, 2021
fmeum
commented
- Reference documentation that explains when to use Label rather than a label string.
- Remove mention of constraint_settings as they can't be used as select keys.
* Reference documentation that explains when to use Label rather than a label string. * Remove mention of constraint_settings as they can't be used as select keys.
Collaborator
Author
gregestren
approved these changes
Dec 23, 2021
Contributor
gregestren
left a comment
gregestren
left a comment
There was a problem hiding this comment.
Thanks for this followup.
I didn't even notice the bug about constraint_setting, nice catch.
FYI because of the holidays this PR may take more time than usual to get merged. Apologies for that, but we'll get it in.
gregestren
reviewed
Dec 24, 2021
src/main/java/com/google/devtools/build/lib/packages/StarlarkLibrary.java
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
Member
|
@bazel-io fork 5.1 |
bazel-io
removed
the
potential release blocker
brentleyjones
pushed a commit
to brentleyjones/bazel
that referenced
this pull request
Feb 9, 2022
* Reference documentation that explains when to use Label rather than a label string. * Remove mention of constraint_settings as they can't be used as select keys. Closes bazelbuild#14458. PiperOrigin-RevId: 420129541 (cherry picked from commit 67a133b)
Wyverald
pushed a commit
that referenced
this pull request
Feb 9, 2022
* Reference documentation that explains when to use Label rather than a label string. * Remove mention of constraint_settings as they can't be used as select keys. Closes #14458. PiperOrigin-RevId: 420129541 (cherry picked from commit 67a133b) Co-authored-by: Fabian Meumertzheim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.