Add support for param files for Android NDK #14457
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Friendly ping on this. |
Member
|
The change makes sense for me from a Windows perspective, but still need @ahumesky to review the actual toolchain change for Android NDK. |
ckolli5
added
the
awaiting-review
ted-xie
approved these changes
May 11, 2022
Contributor
ted-xie
left a comment
ted-xie
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the PR, and especially thanks for adding all of the relevant tests. I will work on integrating this upstream.
ShreeM01
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7982
Currently, on Windows,
arcommand can fail when using Android NDK and the arguments length is too long.This PR resolves it by enabling
--features=compiler_param_fileoption for Android NDK, but I'm not sure if all commands in all versions of NDK that should be supported are compatible with this.