Enable user_link_flags_feature for macosx cc_toolchain_config #14275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will cause the values passed in the link_libs parameters to not get silently dropped on macOS 12 Monterey, and fix the problem where the command line dev tools toolchain will output C++ binaries fails to start with a segmentation fault error. Fixes: bazelbuild#14273
Member
|
@nresare looks like you need to sign the CLA here |
Contributor
Author
|
@googlebot I signed it! |
keith
approved these changes
Nov 15, 2021
Member
keith
left a comment
keith
left a comment
There was a problem hiding this comment.
I can't reproduce this, I assume because I installed Xcode which altered the system some way. But This not being here seems like an oversight anyways so it seems like a good fix
Contributor
Author
|
@google-cla I signed it! |
Member
|
@gregestren since you were triaging related issues maybe you can help get this merged? It should fix #14216 // @oquenchil |
EdSchouten
approved these changes
Nov 22, 2021
Contributor
|
Maybe worth cherry-picking this onto the 4.2 branch and releasing a 4.2.2? Seems pretty serious if you ask me. |
Contributor
|
@keith happy to but since I'm not a domain expert here my main role is going to be routing. I assigned to the Rules / CPP team and @comius team lead according to triage policy. Also CC'ing @meteorcloudy and @Wyverald who are listed at #14013 re: qualifying for a 4.2 branch. |
13 tasks
nresare
added a commit
to nresare/bazel
that referenced
this pull request
Nov 23, 2021
This will cause the values passed in the link_libs parameters to not get silently dropped on macOS 12 Monterey, and fix the problem where the command line dev tools toolchain will output C++ binaries fails to start with a segmentation fault error. Fixes: bazelbuild#14273 Closes bazelbuild#14275. PiperOrigin-RevId: 411840375
kalbasit
added a commit
to kalbasit/nixpkgs
that referenced
this pull request
Nov 23, 2021
This was fixed by enabling the user_link_flags_feature for macosx cc_toolchain_config. References: - bazelbuild/bazel#14216 - bazelbuild/bazel#14275
meteorcloudy
pushed a commit
that referenced
this pull request
Nov 24, 2021
This will cause the values passed in the link_libs parameters to not get silently dropped on macOS 12 Monterey, and fix the problem where the command line dev tools toolchain will output C++ binaries fails to start with a segmentation fault error. Fixes: #14273 Closes #14275. PiperOrigin-RevId: 411840375
nresare
added a commit
to nresare/bazel
that referenced
this pull request
Nov 24, 2021
This will cause the values passed in the link_libs parameters to not get silently dropped on macOS 12 Monterey, and fix the problem where the command line dev tools toolchain will output C++ binaries fails to start with a segmentation fault error. Fixes: bazelbuild#14273 Closes bazelbuild#14275. PiperOrigin-RevId: 411840375
meteorcloudy
pushed a commit
that referenced
this pull request
Nov 24, 2021
This will cause the values passed in the link_libs parameters to not get silently dropped on macOS 12 Monterey, and fix the problem where the command line dev tools toolchain will output C++ binaries fails to start with a segmentation fault error. Fixes: #14273 Closes #14275. PiperOrigin-RevId: 411840375
kalbasit
added a commit
to NixOS/nixpkgs
that referenced
this pull request
Nov 24, 2021
This was fixed by enabling the user_link_flags_feature for macosx cc_toolchain_config. References: - bazelbuild/bazel#14216 - bazelbuild/bazel#14275
github-actions bot
pushed a commit
to NixOS/nixpkgs
that referenced
this pull request
Nov 24, 2021
This was fixed by enabling the user_link_flags_feature for macosx cc_toolchain_config. References: - bazelbuild/bazel#14216 - bazelbuild/bazel#14275 (cherry picked from commit dc8d4f3)
github-actions bot
pushed a commit
to NixOS/nixpkgs
that referenced
this pull request
Nov 24, 2021
This was fixed by enabling the user_link_flags_feature for macosx cc_toolchain_config. References: - bazelbuild/bazel#14216 - bazelbuild/bazel#14275 (cherry picked from commit dc8d4f3)
mkg20001
pushed a commit
to mkg20001/nixpkgs
that referenced
this pull request
Nov 29, 2021
) This was fixed by enabling the user_link_flags_feature for macosx cc_toolchain_config. References: - bazelbuild/bazel#14216 - bazelbuild/bazel#14275
This was referenced Dec 9, 2021
Bencodes
pushed a commit
to Bencodes/bazel
that referenced
this pull request
Jan 10, 2022
This will cause the values passed in the link_libs parameters to not get silently dropped on macOS 12 Monterey, and fix the problem where the command line dev tools toolchain will output C++ binaries fails to start with a segmentation fault error. Fixes: bazelbuild#14273 Closes bazelbuild#14275. PiperOrigin-RevId: 411840375
tholenst
pushed a commit
to tink-crypto/tink
that referenced
this pull request
Feb 3, 2022
bazel 4.2.1 has a problem on MacOS Monterey that was fixed in 4.2.2: bazelbuild/bazel#14275 PiperOrigin-RevId: 425548083
yancl
added a commit
to yancl/bazel
that referenced
this pull request
Nov 3, 2023
fix protoc crash on macos 12.x see bazelbuild#14275
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will cause the values passed in the link_libs parameters
to not get silently dropped on macOS 12 Monterey, and fix
the problem where the command line dev tools toolchain
will output C++ binaries fails to start with a segmentation
fault error.
Fixes: #14273