Fixes for the Starlark transition hash computation#14251
Merged
Wyverald merged 2 commits intobazelbuild:release-5.0.0rc1from Nov 11, 2021
Merged
Fixes for the Starlark transition hash computation#14251Wyverald merged 2 commits intobazelbuild:release-5.0.0rc1from
Wyverald merged 2 commits intobazelbuild:release-5.0.0rc1from
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Wyverald These two commits fix a whole cluster of issues around wrongly calculated transition hashes, leading to action conflicts on otherwise correct builds. I think they would be very useful to have in Bazel 5.
@sdtwigg FYI