[5.x] Remove DigestUtils.getDigestInExclusiveMode() now that SsdModule has …#14242
[5.x] Remove DigestUtils.getDigestInExclusiveMode() now that SsdModule has …#14242Wyverald merged 1 commit intobazelbuild:release-5.0.0rc1from
Conversation
…been removed There used to be a cli flag --experimental_multi_threaded_digest which defaulted to true and therefore would not compute the file digest in exclusive mode unless overridden to false. When that flag was removed this code was accidentally left behind which instead causes bazel to always compute file digests in exclusive mode for all files larger than MULTI_THREADED_DIGEST_MAX_FILE_SIZE. This causes bazel to take 5-6x longer to 'check cached actions' in my org's builds, specifically increasing the time from 30 secs to 2 mins 30 secs for fully cached no-op builds. Fixes bazelbuild#14034 Closes bazelbuild#14231. PiperOrigin-RevId: 407790990 (cherry picked from commit 77a002c)
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
@bjacklyn see the google-cla message |
|
@googlebot I consent. |
3 participants
…been removed
There used to be a cli flag --experimental_multi_threaded_digest which defaulted to true
and therefore would not compute the file digest in exclusive mode unless overridden to false.
When that flag was removed this code was accidentally left behind which instead causes bazel to always
compute file digests in exclusive mode for all files larger than MULTI_THREADED_DIGEST_MAX_FILE_SIZE.
This causes bazel to take 5-6x longer to 'check cached actions' in my org's builds,
specifically increasing the time from 30 secs to 2 mins 30 secs for fully cached no-op builds.
Fixes #14034
Closes #14231.
PiperOrigin-RevId: 407790990
(cherry picked from commit 77a002c)