Remove DigestUtils.getDigestInExclusiveMode() now that SsdModule has …#14231
Closed
bjacklyn wants to merge 1 commit intobazelbuild:masterfrom
Closed
Remove DigestUtils.getDigestInExclusiveMode() now that SsdModule has …#14231bjacklyn wants to merge 1 commit intobazelbuild:masterfrom
bjacklyn wants to merge 1 commit intobazelbuild:masterfrom
Conversation
…been removed There used to be a cli flag --experimental_multi_threaded_digest which defaulted to true and therefore would not compute the file digest in exclusive mode unless overridden to false. When that flag was removed this code was accidentally left behind which instead causes bazel to always compute file digests in exclusive mode for all files larger than MULTI_THREADED_DIGEST_MAX_FILE_SIZE. This causes bazel to take 5-6x longer to 'check cached actions' in my org's builds, specifically increasing the time from 30 secs to 2 mins 30 secs for fully cached no-op builds. Fixes bazelbuild#14034
Author
Wyverald
approved these changes
Nov 5, 2021
Member
Wyverald
left a comment
Wyverald
left a comment
There was a problem hiding this comment.
Thanks for the fix! I'll merge this shortly.
meisterT
pushed a commit
to meisterT/bazel
that referenced
this pull request
Nov 8, 2021
…been removed There used to be a cli flag --experimental_multi_threaded_digest which defaulted to true and therefore would not compute the file digest in exclusive mode unless overridden to false. When that flag was removed this code was accidentally left behind which instead causes bazel to always compute file digests in exclusive mode for all files larger than MULTI_THREADED_DIGEST_MAX_FILE_SIZE. This causes bazel to take 5-6x longer to 'check cached actions' in my org's builds, specifically increasing the time from 30 secs to 2 mins 30 secs for fully cached no-op builds. Fixes bazelbuild#14034 Closes bazelbuild#14231. PiperOrigin-RevId: 407790990 (cherry picked from commit 77a002c)
Wyverald
pushed a commit
that referenced
this pull request
Nov 8, 2021
#14242) …been removed There used to be a cli flag --experimental_multi_threaded_digest which defaulted to true and therefore would not compute the file digest in exclusive mode unless overridden to false. When that flag was removed this code was accidentally left behind which instead causes bazel to always compute file digests in exclusive mode for all files larger than MULTI_THREADED_DIGEST_MAX_FILE_SIZE. This causes bazel to take 5-6x longer to 'check cached actions' in my org's builds, specifically increasing the time from 30 secs to 2 mins 30 secs for fully cached no-op builds. Fixes #14034 Closes #14231. PiperOrigin-RevId: 407790990 (cherry picked from commit 77a002c) Co-authored-by: Brandon Jacklyn <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…been removed
There used to be a cli flag --experimental_multi_threaded_digest which defaulted to true
and therefore would not compute the file digest in exclusive mode unless overridden to false.
When that flag was removed this code was accidentally left behind which instead causes bazel to always
compute file digests in exclusive mode for all files larger than MULTI_THREADED_DIGEST_MAX_FILE_SIZE.
This causes bazel to take 5-6x longer to 'check cached actions' in my org's builds,
specifically increasing the time from 30 secs to 2 mins 30 secs for fully cached no-op builds.
Fixes #14034