Remote: Display download progress when actions are downloading outputs from remote cache.#13557
Closed
coeuvre wants to merge 6 commits intobazelbuild:masterfrom
Closed
Remote: Display download progress when actions are downloading outputs from remote cache.#13557coeuvre wants to merge 6 commits intobazelbuild:masterfrom
coeuvre wants to merge 6 commits intobazelbuild:masterfrom
Conversation
philwo
approved these changes
Jun 7, 2021
Member
philwo
left a comment
philwo
left a comment
There was a problem hiding this comment.
In general LGTM, very nice UX improvement! Could you split this up into smaller CLs when you send it for internal review please? 😊
Member
Author
|
Thanks! Since this PR is based on #13555, can you also give it a look? |
coeuvre
force-pushed
the
remote-download-details
branch
from
0f5a196 to
cb73b06
Compare
coeuvre
force-pushed
the
remote-download-details
branch
from
78b1d95 to
e199144
Compare
coeuvre
added a commit
to coeuvre/bazel
that referenced
this pull request
Jul 15, 2021
…s from remote cache.
Normally, when executing action with remote cache/execution, the UI only display the "remote"/"remote-cache" strategy:
```
[500 / 1000] 500 actions, 3 running
[Sched] Executing genrule //:test-1;
Executing genrule //:test-2; 2s remote
Executing genrule //:test-3; 3s remote ...
```
However, it doesn't tell users what is happening under the hood. bazelbuild#13555 fixed the confusion which the UI display the action is scheduling while it is actually downloading the outputs.
With this change, Bazel will display the downloads if action is downloading outputs. e.g.
```
[500 / 1000] 500 actions, 3 running
[Sched] Executing genrule //:test-1; 1s remote
Executing genrule //:test-2; Downloading 2.out, 20.1 KiB / 100 KiB; 2s remote
Executing genrule //:test-3; 3s remote ...
```
Add a generic `ActionProgressEvent` which can be reported within action execution to display detailed execution progress for that action.
Closes bazelbuild#13557.
PiperOrigin-RevId: 383224334
coeuvre
added a commit
to coeuvre/bazel
that referenced
this pull request
Jul 15, 2021
…s from remote cache.
Normally, when executing action with remote cache/execution, the UI only display the "remote"/"remote-cache" strategy:
```
[500 / 1000] 500 actions, 3 running
[Sched] Executing genrule //:test-1;
Executing genrule //:test-2; 2s remote
Executing genrule //:test-3; 3s remote ...
```
However, it doesn't tell users what is happening under the hood. bazelbuild#13555 fixed the confusion which the UI display the action is scheduling while it is actually downloading the outputs.
With this change, Bazel will display the downloads if action is downloading outputs. e.g.
```
[500 / 1000] 500 actions, 3 running
[Sched] Executing genrule //:test-1; 1s remote
Executing genrule //:test-2; Downloading 2.out, 20.1 KiB / 100 KiB; 2s remote
Executing genrule //:test-3; 3s remote ...
```
Add a generic `ActionProgressEvent` which can be reported within action execution to display detailed execution progress for that action.
Closes bazelbuild#13557.
PiperOrigin-RevId: 383224334
coeuvre
added a commit
to coeuvre/bazel
that referenced
this pull request
Jul 15, 2021
…s from remote cache.
Normally, when executing action with remote cache/execution, the UI only display the "remote"/"remote-cache" strategy:
```
[500 / 1000] 500 actions, 3 running
[Sched] Executing genrule //:test-1;
Executing genrule //:test-2; 2s remote
Executing genrule //:test-3; 3s remote ...
```
However, it doesn't tell users what is happening under the hood. bazelbuild#13555 fixed the confusion which the UI display the action is scheduling while it is actually downloading the outputs.
With this change, Bazel will display the downloads if action is downloading outputs. e.g.
```
[500 / 1000] 500 actions, 3 running
[Sched] Executing genrule //:test-1; 1s remote
Executing genrule //:test-2; Downloading 2.out, 20.1 KiB / 100 KiB; 2s remote
Executing genrule //:test-3; 3s remote ...
```
Add a generic `ActionProgressEvent` which can be reported within action execution to display detailed execution progress for that action.
Closes bazelbuild#13557.
PiperOrigin-RevId: 383224334
coeuvre
added a commit
to coeuvre/bazel
that referenced
this pull request
Jul 15, 2021
…s from remote cache.
Normally, when executing action with remote cache/execution, the UI only display the "remote"/"remote-cache" strategy:
```
[500 / 1000] 500 actions, 3 running
[Sched] Executing genrule //:test-1;
Executing genrule //:test-2; 2s remote
Executing genrule //:test-3; 3s remote ...
```
However, it doesn't tell users what is happening under the hood. bazelbuild#13555 fixed the confusion which the UI display the action is scheduling while it is actually downloading the outputs.
With this change, Bazel will display the downloads if action is downloading outputs. e.g.
```
[500 / 1000] 500 actions, 3 running
[Sched] Executing genrule //:test-1; 1s remote
Executing genrule //:test-2; Downloading 2.out, 20.1 KiB / 100 KiB; 2s remote
Executing genrule //:test-3; 3s remote ...
```
Add a generic `ActionProgressEvent` which can be reported within action execution to display detailed execution progress for that action.
Closes bazelbuild#13557.
PiperOrigin-RevId: 383224334
coeuvre
added a commit
to coeuvre/bazel
that referenced
this pull request
Jul 16, 2021
…s from remote cache.
Normally, when executing action with remote cache/execution, the UI only display the "remote"/"remote-cache" strategy:
```
[500 / 1000] 500 actions, 3 running
[Sched] Executing genrule //:test-1;
Executing genrule //:test-2; 2s remote
Executing genrule //:test-3; 3s remote ...
```
However, it doesn't tell users what is happening under the hood. bazelbuild#13555 fixed the confusion which the UI display the action is scheduling while it is actually downloading the outputs.
With this change, Bazel will display the downloads if action is downloading outputs. e.g.
```
[500 / 1000] 500 actions, 3 running
[Sched] Executing genrule //:test-1; 1s remote
Executing genrule //:test-2; Downloading 2.out, 20.1 KiB / 100 KiB; 2s remote
Executing genrule //:test-3; 3s remote ...
```
Add a generic `ActionProgressEvent` which can be reported within action execution to display detailed execution progress for that action.
Closes bazelbuild#13557.
PiperOrigin-RevId: 383224334
larsrc-google
pushed a commit
to larsrc-google/bazel
that referenced
this pull request
Jul 28, 2021
…s from remote cache.
Normally, when executing action with remote cache/execution, the UI only display the "remote"/"remote-cache" strategy:
```
[500 / 1000] 500 actions, 3 running
[Sched] Executing genrule //:test-1;
Executing genrule //:test-2; 2s remote
Executing genrule //:test-3; 3s remote ...
```
However, it doesn't tell users what is happening under the hood. bazelbuild#13555 fixed the confusion which the UI display the action is scheduling while it is actually downloading the outputs.
With this change, Bazel will display the downloads if action is downloading outputs. e.g.
```
[500 / 1000] 500 actions, 3 running
[Sched] Executing genrule //:test-1; 1s remote
Executing genrule //:test-2; Downloading 2.out, 20.1 KiB / 100 KiB; 2s remote
Executing genrule //:test-3; 3s remote ...
```
Add a generic `ActionProgressEvent` which can be reported within action execution to display detailed execution progress for that action.
Closes bazelbuild#13557.
PiperOrigin-RevId: 383224334
larsrc-google
pushed a commit
to larsrc-google/bazel
that referenced
this pull request
Jul 30, 2021
…s from remote cache.
Normally, when executing action with remote cache/execution, the UI only display the "remote"/"remote-cache" strategy:
```
[500 / 1000] 500 actions, 3 running
[Sched] Executing genrule //:test-1;
Executing genrule //:test-2; 2s remote
Executing genrule //:test-3; 3s remote ...
```
However, it doesn't tell users what is happening under the hood. bazelbuild#13555 fixed the confusion which the UI display the action is scheduling while it is actually downloading the outputs.
With this change, Bazel will display the downloads if action is downloading outputs. e.g.
```
[500 / 1000] 500 actions, 3 running
[Sched] Executing genrule //:test-1; 1s remote
Executing genrule //:test-2; Downloading 2.out, 20.1 KiB / 100 KiB; 2s remote
Executing genrule //:test-3; 3s remote ...
```
Add a generic `ActionProgressEvent` which can be reported within action execution to display detailed execution progress for that action.
Closes bazelbuild#13557.
PiperOrigin-RevId: 383224334
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normally, when executing action with remote cache/execution, the UI only display the "remote"/"remote-cache" strategy:
However, it doesn't tell users what is happening under the hood. #13555 fixed the confusion which the UI display the action is scheduling while it is actually downloading the outputs.
With this change, Bazel will display the downloads if action is downloading outputs. e.g.
Add a generic
ActionProgressEventwhich can be reported within action execution to display detailed execution progress for that action.