Suppress interrupted status during pool closure#13521
Closed
werkt wants to merge 1 commit intobazelbuild:masterfrom
Closed
Suppress interrupted status during pool closure#13521werkt wants to merge 1 commit intobazelbuild:masterfrom
werkt wants to merge 1 commit intobazelbuild:masterfrom
Conversation
awaitTermination will throw InterruptedException if the interrupted status is set initially when it is called, even if no wait is required. Pool closure should not respect active interrupted status when shutting down and awaiting termination as a result of its call from executionPhaseEnding, which will occur during abnormal exits from ExecutionTool. Ignore this status initially and restore the flag upon exit of the factory close. An external interrupt which occurs during the awaitTermination will still trigger an InterruptedException, as expected. Fixes bazelbuild#13512
katre
pushed a commit
that referenced
this pull request
Jul 12, 2021
awaitTermination will throw InterruptedException if the interrupted status is set initially when it is called, even if no wait is required. Pool closure should not respect active interrupted status when shutting down and awaiting termination as a result of its call from executionPhaseEnding, which will occur during abnormal exits from ExecutionTool. Ignore this status initially and restore the flag upon exit of the factory close. An external interrupt which occurs during the awaitTermination will still trigger an InterruptedException, as expected. Fixes #13512 Closes #13521. PiperOrigin-RevId: 377006347
Contributor
|
@werkt If there was an InterruptedException during the That seems to be the case we hit below. Bazel version is 6.1.0. The line in the stack trace |
Contributor
Author
|
Yes, from your stack traces there, and from confirming via code sources, I expect that, particularly given the block of submittedTasks processing in BlockWaitingModule, only AbruptExitExceptions are handled in any non-terminating fashion, with your Interrupted -> IO -> Assertion -> Execution -> Runtime exception path there resulting in a shutdown in BlazeCommandDispatcher with the copy "Shutting down due to exception". Ostensibly, you really don't want anything but a complete failure+shutdown in the bazel daemon here, as it just failed to shutdown a pool, so it would leak resources if it continued. |
Contributor
|
Roger. Thanks for confirming. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
awaitTermination will throw InterruptedException if the interrupted
status is set initially when it is called, even if no wait is required.
Pool closure should not respect active interrupted status when shutting
down and awaiting termination as a result of its call from
executionPhaseEnding, which will occur during abnormal exits from
ExecutionTool. Ignore this status initially and restore the flag upon
exit of the factory close. An external interrupt which occurs during the
awaitTermination will still trigger an InterruptedException, as
expected.
Fixes #13512