cquery inherits from test not build#13491
cquery inherits from test not build#13491illicitonion wants to merge 1 commit intobazelbuild:masterfrom
test not build#13491Conversation
jin
added
the
team-Configurability
|
Just want to confirm, after #13428 (comment), that this is the route you want to go. Also a nitpick on the description: this means cquery picks up .bazelrc directives of the form: right? For example, I expect cquery already picks up but not |
gregestren
left a comment
gregestren
left a comment
There was a problem hiding this comment.
Can we add a quick test to block regression? https://github.com/bazelbuild/bazel/blob/080ef6eba08e8e5329c7135d39378d5841ee417f/src/test/shell/integration/configured_query_test.sh looks like the best place to me (I can't find any dedicated bazelrc tests).
illicitonion
force-pushed
the
cquery-inherits-test
branch
from
6a6cc2a to
6d9f81e
Compare
This makes flags like `--test_arg` present in `.bazelrc` files be factored into the configuration hash for test targets. See bazelbuild#13428 for extensive context.
illicitonion
force-pushed
the
cquery-inherits-test
branch
from
6d9f81e to
91a9443
Compare
This makes directives like `test --test_arg=foo` present in `.bazelrc` files be factored into the configuration hash for test targets. See bazelbuild#13428 for extensive context. Closes bazelbuild#13491. PiperOrigin-RevId: 382143334
This makes directives like `test --test_arg=foo` present in `.bazelrc` files be factored into the configuration hash for test targets. See bazelbuild#13428 for extensive context. Closes bazelbuild#13491. PiperOrigin-RevId: 382143334
|
This seems to have broken |
Sorry for the breakge! I don't think this is expected - let's follow up on that issue. |
4 participants
This makes directives like
test --test_arg=foopresent in.bazelrcfiles befactored into the configuration hash for test targets.
See #13428 for extensive
context.