Cleanup: Replace NULL with nullptr#13168
Closed
Vertexwahn wants to merge 1 commit intobazelbuild:masterfrom
Vertexwahn:cleanup-null-ptr
Closed
Cleanup: Replace NULL with nullptr#13168Vertexwahn wants to merge 1 commit intobazelbuild:masterfrom Vertexwahn:cleanup-null-ptr
Vertexwahn wants to merge 1 commit intobazelbuild:masterfrom
Vertexwahn:cleanup-null-ptr
Conversation
At several places, NULL and nullptr were mixed. This commit cleans this up and switches NULL to nullptr where appropriate.
Member
|
Philipp, do you know who we can triage this to? Looks fairly simple but I'm not a C++ person or familiar with our C++ code. |
philwo
added
P1
Member
|
@brandjon I'll try to import this, maybe it'll just go through without issues. :) |
Member
|
@Vertexwahn Thank you for this. The presubmit tests are running at the moment and when they pass, it'll be merged automatically. :) Just FYI, while importing I noticed a few more lines in |
larsrc-google
pushed a commit
to larsrc-google/bazel
that referenced
this pull request
Jul 28, 2021
At several places, NULL and nullptr were mixed. This commit cleans this up and switches NULL to nullptr where appropriate. Closes bazelbuild#13168. PiperOrigin-RevId: 362043567
larsrc-google
pushed a commit
to larsrc-google/bazel
that referenced
this pull request
Jul 30, 2021
At several places, NULL and nullptr were mixed. This commit cleans this up and switches NULL to nullptr where appropriate. Closes bazelbuild#13168. PiperOrigin-RevId: 362043567
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At several places, NULL and nullptr were mixed. This commit cleans this up and switches NULL to nullptr where appropriate.