Documentation for #13110 #13167
Closed
Documentation for #13110 #13167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quval
requested review from
aiuto,
floriographygoth,
gregestren and
jin
as code owners
This was referenced Mar 6, 2021
katre
suggested changes
Mar 8, 2021
Collaborator
katre
left a comment
katre
left a comment
There was a problem hiding this comment.
Thanks! I left one comment, but in general can you please clarify that this is coming from execution platforms, not target platforms?
site/docs/exec-groups.md
Outdated
| It is possible to define `exec_properties` for arbitrary execution groups on | ||
| platform targets (unlike `exec_properties` set directly on a target, where | ||
| properties for unknown execution groups are rejected). Targets then inherit the | ||
| platform's `exec_properties` that affect the default execution group and any |
Collaborator
There was a problem hiding this comment.
"Targets then inherit the execution platform's exec_proeprties"
Contributor
Author
There was a problem hiding this comment.
Done (here and in one other place) - not sure if it should be made clearer.
Contributor
Author
|
Thank you! |
philwo
pushed a commit
that referenced
this pull request
Mar 15, 2021
Closes #13167. PiperOrigin-RevId: 361885312
philwo
pushed a commit
that referenced
this pull request
Mar 15, 2021
Closes #13167. PiperOrigin-RevId: 361885312
katre
pushed a commit
that referenced
this pull request
Jul 12, 2021
Closes #13167. PiperOrigin-RevId: 361885312
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@katre