Skip to content

Update turbine#13145

Closed
cushon wants to merge 1 commit intobazelbuild:masterfrom
cushon:turbine
Closed

Update turbine#13145
cushon wants to merge 1 commit intobazelbuild:masterfrom
cushon:turbine

Conversation

@cushon
Copy link
Copy Markdown
Contributor

@cushon cushon commented Mar 3, 2021

@google-cla google-cla Bot added the cla: yes label Mar 3, 2021
@cushon cushon requested review from comius and philwo March 3, 2021 01:40
Copy link
Copy Markdown
Contributor

@comius comius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github says it's an empty file?

@cushon
Copy link
Copy Markdown
Contributor Author

cushon commented Mar 3, 2021

Github says it's an empty file?

I think that's just a github UI issue.

If I click through to https://github.com/bazelbuild/bazel/blob/eaa0f54301d50ed0671583620ef34b6864976366/third_party/turbine/turbine_direct.jar and download it, it is non-empty and has the expected entries.

@philwo
Copy link
Copy Markdown
Member

philwo commented Mar 3, 2021

I'll merge this (and verify before pushing that the file is non-empty 😊)

bazel-io pushed a commit that referenced this pull request Mar 3, 2021
Built at
google/turbine@617a8f6

Partial commit for third_party/*, see #13145.

Signed-off-by: Philipp Wollermann <[email protected]>
@philwo
Copy link
Copy Markdown
Member

philwo commented Mar 3, 2021

Merged in 57672ac

@philwo philwo closed this Mar 3, 2021
Bencodes pushed a commit to Bencodes/bazel that referenced this pull request Mar 24, 2021
Built at
google/turbine@617a8f6

Partial commit for third_party/*, see bazelbuild#13145.

Signed-off-by: Philipp Wollermann <[email protected]>
comius pushed a commit that referenced this pull request Nov 9, 2021
Built at
google/turbine@617a8f6

Partial commit for third_party/*, see #13145.

Signed-off-by: Philipp Wollermann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Turbine breaks ASWB IDE sync for projects using Robolectric (android_local_test)

3 participants