Skip to content

Set Platform on Action not just Command#13134

Closed
illicitonion wants to merge 1 commit intobazelbuild:masterfrom
illicitonion:platform-on-action
Closed

Set Platform on Action not just Command#13134
illicitonion wants to merge 1 commit intobazelbuild:masterfrom
illicitonion:platform-on-action

Conversation

@illicitonion
Copy link
Copy Markdown
Contributor

bazelbuild/remote-apis#167 promoted the field,
but left the old one present for legacy fallback for remote execution
platforms which haven't updated yet.

This PR sets both.

@google-cla google-cla Bot added the cla: yes label Mar 1, 2021
@illicitonion
Copy link
Copy Markdown
Contributor Author

This depends on #13133

@EdSchouten
Copy link
Copy Markdown
Contributor

Cc @coeuvre @philwo

@illicitonion illicitonion force-pushed the platform-on-action branch 3 times, most recently from 82ef52e to 928abb2 Compare March 1, 2021 17:40
@jin jin added the team-Remote-Exec Issues and PRs for the Execution (Remote) team label Mar 2, 2021
@coeuvre coeuvre self-requested a review March 3, 2021 09:30
Copy link
Copy Markdown
Member

@coeuvre coeuvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#13133 is merged. Please rebase and I will merge this.

bazelbuild/remote-apis#167 promoted the field,
but left the old one present for legacy fallback for remote execution
platforms which haven't updated yet.

This PR sets both.
@illicitonion
Copy link
Copy Markdown
Contributor Author

Rebased :) Thanks!

@bazel-io bazel-io closed this in dad9630 Mar 3, 2021
philwo pushed a commit that referenced this pull request Mar 15, 2021
bazelbuild/remote-apis#167 promoted the field,
but left the old one present for legacy fallback for remote execution
platforms which haven't updated yet.

This PR sets both.

Closes #13134.

PiperOrigin-RevId: 360647520
philwo pushed a commit that referenced this pull request Mar 15, 2021
bazelbuild/remote-apis#167 promoted the field,
but left the old one present for legacy fallback for remote execution
platforms which haven't updated yet.

This PR sets both.

Closes #13134.

PiperOrigin-RevId: 360647520
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes team-Remote-Exec Issues and PRs for the Execution (Remote) team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants