Skip to content

Move --repo_env to common options#13003

Closed
chancila wants to merge 5 commits intobazelbuild:masterfrom
chancila:move_repo_env_to_common
Closed

Move --repo_env to common options#13003
chancila wants to merge 5 commits intobazelbuild:masterfrom
chancila:move_repo_env_to_common

Conversation

@chancila
Copy link
Copy Markdown
Contributor

@chancila chancila commented Feb 12, 2021 •
edited
Loading

Move --repo_env into common options and inject the value through CommandEnvironment since CommonCommandOptions cannot be accessed in SkyframeExecutor directly due to a circular dependency in the build.

Addresses #12689

@google-cla google-cla Bot added the cla: yes label Feb 12, 2021
@chancila chancila changed the title [testing] Move --repo_env to common options [wip][testing] Move --repo_env to common options Feb 12, 2021
@chancila chancila changed the title [wip][testing] Move --repo_env to common options Move --repo_env to common options Feb 12, 2021
nkoroste pushed a commit to nkoroste/bazel that referenced this pull request Feb 23, 2021
@chancilasnap
Move --repo_env to common options
18f2809 
--repo_env should be a common option, it causes issues with repository syncing.

Upstream PR: bazelbuild#13003
---
Automatic squash commit from https://github.sc-corp.net/Snapchat/bazel/pull/93
Cooled by chancila
@google-cla
Copy link
Copy Markdown

google-cla Bot commented Feb 25, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla Bot added cla: no and removed cla: yes labels Feb 25, 2021
@chancila chancila force-pushed the move_repo_env_to_common branch from 9a0e0c2 to cdd0da5 Compare February 25, 2021 20:05
@google-cla google-cla Bot added cla: yes and removed cla: no labels Feb 25, 2021
@chancila
Copy link
Copy Markdown
Contributor Author

chancila commented Feb 26, 2021

@googlebot I fixed it.

@jin jin added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website labels Mar 1, 2021
@chancila
Copy link
Copy Markdown
Contributor Author

chancila commented Mar 1, 2021

not really sure why the rbe action fails...

(21:07:09) ERROR: /workdir/src/test/java/com/google/devtools/build/lib/skyframe/BUILD:74:10: Testing //src/test/java/com/google/devtools/build/lib/skyframe:SkyframeTests (shard 18 of 20) failed: (Exit 34): java.io.IOException: io.grpc.StatusRuntimeException: FAILED_PRECONDITION: there are no bots capable of executing the action, requested action properties: OSFamily = Linux, gceMachineType = n1-highcpu-32

@philwo
Copy link
Copy Markdown
Member

philwo commented Mar 25, 2021

Thank you @chancila! I'm merging this now.

@bazel-io bazel-io closed this in c2bdd03 Mar 25, 2021
philwo pushed a commit that referenced this pull request Apr 21, 2021
@chancila @philwo
Move --repo_env to common options
d737177 
Move --repo_env into common options and inject the value through CommandEnvironment since CommonCommandOptions cannot be accessed in SkyframeExecutor directly due to a circular dependency in the build.

Addresses #12689

Closes #13003.

PiperOrigin-RevId: 365035772
@philwo philwo removed the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@philwo philwo philwo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@philwo philwo

Labels

cla: yes team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chancila @philwo @jin