Update threshold for long path shortening to be MAX_PATH - 4#12941
Closed
mai93 wants to merge 1 commit intobazelbuild:masterfrom
Closed
Update threshold for long path shortening to be MAX_PATH - 4#12941mai93 wants to merge 1 commit intobazelbuild:masterfrom
mai93 wants to merge 1 commit intobazelbuild:masterfrom
Conversation
mai93
changed the title
jin
added
area-Windows
meteorcloudy
approved these changes
Mar 11, 2021
Member
meteorcloudy
left a comment
meteorcloudy
left a comment
There was a problem hiding this comment.
Nit: We still don't have a reproduce case without RBE? Otherwise, adding a test would be a good idea.
mai93
changed the title
Contributor
Author
|
Yes, I could not reproduce it without RBE. |
meteorcloudy
approved these changes
Mar 11, 2021
Member
meteorcloudy
left a comment
meteorcloudy
left a comment
There was a problem hiding this comment.
Thanks for confirming, let's import this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR applies the suggested fix for #12310. Although I could not reproduce it.
Fixes: #12310