Clarify test_suite behaviour in the Platforms docs#12870
Closed
philsc wants to merge 1 commit intobazelbuild:masterfrom
Closed
Clarify test_suite behaviour in the Platforms docs#12870philsc wants to merge 1 commit intobazelbuild:masterfrom
philsc wants to merge 1 commit intobazelbuild:masterfrom
Conversation
philsc
requested review from
aiuto,
floriographygoth,
gregestren and
jin
as code owners
gregestren
reviewed
Jan 21, 2021
Contributor
gregestren
left a comment
gregestren
left a comment
There was a problem hiding this comment.
Nice catch! This is a good, and I think relevant, clarification.
The current `test_suite` behaviour in regards to incompatible target skipping is subtle and not necessarily obvious. This patch aims to clear up some of the confusion.
philsc
force-pushed
the
platforms-doc-update
branch
from
62853f2 to
3afff63
Compare
gregestren
approved these changes
Jan 22, 2021
Contributor
gregestren
left a comment
gregestren
left a comment
There was a problem hiding this comment.
Thanks for considering such nitty suggestions!
philwo
pushed a commit
that referenced
this pull request
Mar 15, 2021
The current `test_suite` behaviour in regards to incompatible target skipping is subtle and not necessarily obvious. This patch aims to clear up some of the confusion. Closes #12870. PiperOrigin-RevId: 353293585
philwo
pushed a commit
that referenced
this pull request
Mar 15, 2021
The current `test_suite` behaviour in regards to incompatible target skipping is subtle and not necessarily obvious. This patch aims to clear up some of the confusion. Closes #12870. PiperOrigin-RevId: 353293585
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current
test_suitebehaviour in regards to incompatible targetskipping is subtle and not necessarily obvious. This patch aims to
clear up some of the confusion.