Add windows_msvc back to conditions in bazel_tools.#12668
Closed
comius wants to merge 1 commit intobazelbuild:masterfrom
Closed
Add windows_msvc back to conditions in bazel_tools.#12668comius wants to merge 1 commit intobazelbuild:masterfrom
comius wants to merge 1 commit intobazelbuild:masterfrom
Conversation
This is partial revert of 6d637f4 and a fix to a06d7e1, which went into wrong file. windows_msvc condition is used downstream by tensorflow via ruy. The culprit line is in https://github.com/google/ruy/blob/master/ruy/build_defs.bzl#L60 (and #L67,#L77).
katre
approved these changes
Dec 9, 2020
meisterT
pushed a commit
that referenced
this pull request
Jan 13, 2021
This is partial revert of 6d637f4 and a fix to a06d7e1, which went into wrong file. windows_msvc condition is used downstream by tensorflow via ruy. The culprit line is in https://github.com/google/ruy/blob/master/ruy/build_defs.bzl#L60 (and #L67,#L77). Closes #12668. PiperOrigin-RevId: 346540473 (cherry picked from commit 88b1cb4)
meisterT
pushed a commit
that referenced
this pull request
Jan 13, 2021
This is partial revert of 6d637f4 and a fix to a06d7e1, which went into wrong file. windows_msvc condition is used downstream by tensorflow via ruy. The culprit line is in https://github.com/google/ruy/blob/master/ruy/build_defs.bzl#L60 (and #L67,#L77). Closes #12668. PiperOrigin-RevId: 346540473
ulfjack
pushed a commit
to EngFlow/bazel
that referenced
this pull request
Mar 5, 2021
This is partial revert of 6d637f4 and a fix to a06d7e1, which went into wrong file. windows_msvc condition is used downstream by tensorflow via ruy. The culprit line is in https://github.com/google/ruy/blob/master/ruy/build_defs.bzl#L60 (and #L67,#L77). Closes bazelbuild#12668. PiperOrigin-RevId: 346540473
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is partial revert of 6d637f4 and a fix to a06d7e1, which went into wrong file.
windows_msvc condition is used downstream by tensorflow via ruy.
The culprit line is in https://github.com/google/ruy/blob/master/ruy/build_defs.bzl#L60 (and #L67,#L77).