Skip to content

Support Shenandoah and ZGC#12644

Closed
trustin wants to merge 2 commits intobazelbuild:masterfrom
trustin:patch-1
Closed

Support Shenandoah and ZGC#12644
trustin wants to merge 2 commits intobazelbuild:masterfrom
trustin:patch-1

Conversation

@trustin
Copy link
Copy Markdown
Contributor

@trustin trustin commented Dec 7, 2020

Bazel currently refuses to start up when JVM is launched with -XX:+UseShenandoahGC or
-XX:+UseZGC. This can be easily fixed by making RetainedHeapLimiter recognize the
memory pool name Shenandoah and ZHeap.

Bazel currently refuses to start up when JVM is launched with `-XX:+UseShenandoahGC`.
This can be easily fixed by making `RetainedHeapLimiter` recognize the memory pool name
`Shenandoah`.
@google-cla google-cla Bot added the cla: yes label Dec 7, 2020
@jin jin added the team-Rules-Java Issues for Java rules label Dec 7, 2020
@trustin trustin changed the title Support Shenandoah GC Support Shenandoah and ZGC Dec 7, 2020
apattidb pushed a commit to databricks/bazel that referenced this pull request Dec 8, 2020
Bazel currently refuses to start up when JVM is launched with `-XX:+UseShenandoahGC` or
`-XX:+UseZGC`. This can be easily fixed by making `RetainedHeapLimiter` recognize the
memory pool name `Shenandoah` and `ZHeap`.

Upstream: bazelbuild#12644
@bazel-io bazel-io closed this in f23aa21 Dec 8, 2020
@trustin trustin deleted the patch-1 branch December 9, 2020 04:41
jjudd added a commit to lucidsoftware/bazel that referenced this pull request Aug 1, 2025
Bazel currently does not start when you launch the server JVM with
generational ZGC using -XX:+UseZGC and -XX:+ZGenerational. Or if you're
on JDK 24+ the same problem is encountered with just -XX:+UseZGC.

The same problem is encountered with -XX:+UseShenandoahGC and
-XX:ShenandoahGCMode=generational.

Non-generational ZGC is removed as of JDK 24. Generational Shenandoah is
being promoted from experimental to production in JDK 25.

This fix is modeled after bazelbuild#12644
jjudd added a commit to lucidsoftware/bazel that referenced this pull request Aug 1, 2025
Bazel currently does not start when you launch the server JVM with
generational ZGC using -XX:+UseZGC and -XX:+ZGenerational. Or if you're
on JDK 24+ the same problem is encountered with just -XX:+UseZGC.

The same problem is encountered with -XX:+UseShenandoahGC and
-XX:ShenandoahGCMode=generational.

Non-generational ZGC is removed as of JDK 24. Generational Shenandoah is
being promoted from experimental to production in JDK 25.

This fix is modeled after bazelbuild#12644
copybara-service Bot pushed a commit that referenced this pull request Aug 1, 2025
Bazel currently does not start when you launch the server JVM with generational ZGC using `-XX:+UseZGC` and `-XX:+ZGenerational`. Or if you're on JDK 24+ the same problem is encountered with just `-XX:+UseZGC`.

The same problem is encountered with `-XX:+UseShenandoahGC` and `-XX:ShenandoahGCMode=generational`.

Non-generational ZGC is removed as of JDK 24. Generational Shenandoah is being promoted from experimental to production in JDK 25.

This fix is modeled after #12644

Closes #26676.

PiperOrigin-RevId: 789746919
Change-Id: Ia070fa9b39cef07cc9987544c014d589b2504dce
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Aug 1, 2025
Bazel currently does not start when you launch the server JVM with generational ZGC using `-XX:+UseZGC` and `-XX:+ZGenerational`. Or if you're on JDK 24+ the same problem is encountered with just `-XX:+UseZGC`.

The same problem is encountered with `-XX:+UseShenandoahGC` and `-XX:ShenandoahGCMode=generational`.

Non-generational ZGC is removed as of JDK 24. Generational Shenandoah is being promoted from experimental to production in JDK 25.

This fix is modeled after bazelbuild#12644

Closes bazelbuild#26676.

PiperOrigin-RevId: 789746919
Change-Id: Ia070fa9b39cef07cc9987544c014d589b2504dce
github-merge-queue Bot pushed a commit that referenced this pull request Aug 4, 2025
Bazel currently does not start when you launch the server JVM with
generational ZGC using `-XX:+UseZGC` and `-XX:+ZGenerational`. Or if
you're on JDK 24+ the same problem is encountered with just
`-XX:+UseZGC`.

The same problem is encountered with `-XX:+UseShenandoahGC` and
`-XX:ShenandoahGCMode=generational`.

Non-generational ZGC is removed as of JDK 24. Generational Shenandoah is
being promoted from experimental to production in JDK 25.

This fix is modeled after #12644

Closes #26676.

PiperOrigin-RevId: 789746919
Change-Id: Ia070fa9b39cef07cc9987544c014d589b2504dce

Commit
3a1fe64

Co-authored-by: James Judd <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes team-Rules-Java Issues for Java rules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants