Fix common prefix for instrumentation filter#12607
Closed
limdor wants to merge 1 commit intobazelbuild:masterfrom
Closed
Fix common prefix for instrumentation filter#12607limdor wants to merge 1 commit intobazelbuild:masterfrom
limdor wants to merge 1 commit intobazelbuild:masterfrom
Conversation
In case that two path share a prefix, the instrumentation filter is not computed proper. bazelbuild#10949 This PR takes as a base the one that was created by @caiyulun and adds some tests. Original PR: bazelbuild#10949
limdor
commented
Dec 2, 2020
| listOfTargets.add(getTarget("//foo:t")); | ||
| listOfTargets.add(getTarget("//foobar:t")); | ||
| Collection<Target> targets = Collections.unmodifiableCollection(listOfTargets); | ||
| String expectedFilter = "^//foo[/:],^//foobar[/:]"; |
Contributor
Author
There was a problem hiding this comment.
If prefered, I could split the PR in two commits to see more clear how the test would change with the changes.
Before the this PR the expected Filter would have been just ^//foo[/:]
Member
There was a problem hiding this comment.
This is fine. We squash the PR into a single commit anyway, so there's limited value in splitting everything up incrementally in this case.
c-mita
approved these changes
Dec 2, 2020
| listOfTargets.add(getTarget("//foo:t")); | ||
| listOfTargets.add(getTarget("//foobar:t")); | ||
| Collection<Target> targets = Collections.unmodifiableCollection(listOfTargets); | ||
| String expectedFilter = "^//foo[/:],^//foobar[/:]"; |
Member
There was a problem hiding this comment.
This is fine. We squash the PR into a single commit anyway, so there's limited value in splitting everything up incrementally in this case.
Contributor
Author
|
@c-mita some checks are failing but looks more like an http error connection. |
Member
|
@c-mita and me are merging this right now and I'll make sure to get it into Bazel 4.0.0rc3! :) |
philwo
pushed a commit
that referenced
this pull request
Dec 7, 2020
philwo
pushed a commit
that referenced
this pull request
Dec 9, 2020
philwo
pushed a commit
that referenced
this pull request
Dec 10, 2020
ulfjack
pushed a commit
to EngFlow/bazel
that referenced
this pull request
Mar 5, 2021
In case that two path share a prefix, the instrumentation filter is not computed proper. bazelbuild#10949 This PR takes as a base the one that was created by @caiyulun and adds some tests. Original PR: bazelbuild#10949 Closes bazelbuild#12607. PiperOrigin-RevId: 346097533
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case that two path share a prefix, the instrumentation filter is
not computed proper.
#10949
This PR takes as a base the one that was created by @caiyulun and
adds some tests.
Original PR: #10949