Patch grpc to fix cares selecting the wrong source when building for darwin_arm64 cpu.#12594
Closed
thii wants to merge 1 commit intobazelbuild:masterfrom
Closed
Conversation
darwin_arm64 cpu. This should use constraints instead of cpu flags, but that should be fixed on the grpc repository. I just added new `config_setting`s here to keep the patch size small. This should allow building a Bazel binary for Apple Silicon hardware from an Intel Mac with: ``` USE_BAZEL_VERSION=last_green bazel build -c opt --cpu=darwin_arm64 //src:bazel ``` (This needs last green Bazel because we need recent changes to `@bazel_tools` which needs a Bazel release.)
Member
Author
|
(The bazel command above is bazelisk) |
keith
approved these changes
Dec 1, 2020
Member
keith
left a comment
keith
left a comment
There was a problem hiding this comment.
Probably worth submitting upstream too.
Member
Author
|
Thanks, submitted it: grpc/grpc#24872. |
jin
added
area-EngProd
philwo
approved these changes
Dec 7, 2020
thii
deleted the
patch-grpc-to-fix-cares-selecting-the-wrong-source-when-building-for
branch
philwo
pushed a commit
that referenced
this pull request
Mar 15, 2021
…darwin_arm64 cpu. This should use constraints instead of cpu flags, but that should be fixed on the grpc repository. I just added new `config_setting`s here to keep the patch size small. This should allow building a Bazel binary for Apple Silicon hardware from an Intel Mac with: ``` USE_BAZEL_VERSION=last_green bazel build -c opt --cpu=darwin_arm64 //src:bazel ``` (This needs last green Bazel because we need recent changes to `@bazel_tools` which needs a Bazel release.) Closes #12594. Signed-off-by: Philipp Wollermann <[email protected]>
philwo
pushed a commit
that referenced
this pull request
Mar 15, 2021
…darwin_arm64 cpu. This should use constraints instead of cpu flags, but that should be fixed on the grpc repository. I just added new `config_setting`s here to keep the patch size small. This should allow building a Bazel binary for Apple Silicon hardware from an Intel Mac with: ``` USE_BAZEL_VERSION=last_green bazel build -c opt --cpu=darwin_arm64 //src:bazel ``` (This needs last green Bazel because we need recent changes to `@bazel_tools` which needs a Bazel release.) Closes #12594. Signed-off-by: Philipp Wollermann <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should use constraints instead of cpu flags, but that should be
fixed on the grpc repository. I just added new
config_settingshere to keep the patch size small.
This should allow building a Bazel binary for Apple Silicon hardware
from an Intel Mac with:
(This needs last green Bazel because we need recent changes to
@bazel_toolswhich needs a Bazel release.)