@philwo

Ideally this would be conditional on clang instead I guess?

Thank you! Happy to merge this when presubmits pass.

Unfortunately I don't know how to use compiler specific cflags. :/ @oquenchil Any idea?

Envoy uses:

config_setting(
    name = "clang_build",
    flag_values = {
        "@bazel_tools//tools/cpp:compiler": "clang",
    },
)

But testing this quickly on macOS this doesn't seem to work

Where is the error log? It looks like all presubmits are passing.

That compiler target is here . By looking at the Starlark implementation of the rule, it looks like it takes the compiler string as is, it might be that on macOS is not just clang but something slightly different.

There isn't an error when I use that config it just doesn't match on macOS and the warnings are still produced in the console

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

#12463

This becomes obsolete after the revert.