Use constraints in global conditions instead of configuration flags.#12427
Closed
comius wants to merge 6 commits intobazelbuild:masterfrom
Closed
Use constraints in global conditions instead of configuration flags.#12427comius wants to merge 6 commits intobazelbuild:masterfrom
comius wants to merge 6 commits intobazelbuild:masterfrom
Conversation
comius
requested review from
ahumesky,
alandonovan and
brandjon
as code owners
Contributor
Author
|
Downstream test at https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/1751 (previously failing gerrit, cloudrobotics, flatbuffers) |
katre
approved these changes
Nov 6, 2020
Collaborator
katre
left a comment
katre
left a comment
There was a problem hiding this comment.
Nice to see the reduced duplication.
Contributor
Author
rules_nodejs fix: bazel-contrib/rules_nodejs#2274 |
comius
added a commit
to comius/bazel
that referenced
this pull request
Nov 9, 2020
(third_party/BUILD). This is part of bazelbuild#12427, that changes third_party/BUILD file.
alandonovan
reviewed
Nov 9, 2020
| "//src/conditions:linux_ppc": ["cpu_profiler_posix.cc"], | ||
| "//src/conditions:linux_s390x": ["cpu_profiler_posix.cc"], | ||
| "//src/conditions:linux_x86_64": ["cpu_profiler_posix.cc"], | ||
| "//src/conditions:linux": ["cpu_profiler_posix.cc"], |
bazel-io
pushed a commit
that referenced
this pull request
Nov 9, 2020
…third_party/BUILD). This is part of #12427, that changes third_party/BUILD file. Partial commit for third_party/*, see #12435. Signed-off-by: Philipp Wollermann <[email protected]>
…lags in BUILD.tools.
…ition where appropriate.
comius
force-pushed
the
use-constraints-in-conditions
branch
from
39324fb to
686e08d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I changed configuration settings in //src/conditions to use constraints instead of flags and then fixed some places where this is used.
I fixed uses of darwin and darwin_x86_64, which using flags I believe is the same thing and using constraints actually becomes different.
Added config_setting for linux. Used it where it makes sense. It cannot be used in tools/jdk/..., because it somehow gets new @bazel_tools and old @bazel_tools/constraints.
This might break users of remote execution or cross compiling. The users working on a single platform should be safe.