Skip to content

Update new target_compatible_with attribute to not exist on repository_rules #12378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
katre wants to merge 1 commit into from
Closed

Update new target_compatible_with attribute to not exist on repository_rules #12378

katre wants to merge 1 commit into from

Conversation

@katre
Copy link
Collaborator

@katre katre commented Oct 28, 2020

…y rules.

Fixes #12374.

@katre katre requested a review from gregestren October 28, 2020 16:06
@google-cla google-cla bot added the cla: yes label Oct 28, 2020
@katre
Copy link
Collaborator Author

katre commented Oct 28, 2020

Once the standard tests pass I'll kick off the downstream tests.

@katre
Copy link
Collaborator Author

katre commented Oct 28, 2020

We could consider reverting 4381dbf (patch RBE's use of target_compatible_with) and 8946cc1 (actually applies the patch) after this is in, if we wanted to clean up our WORKSPACE slightly.

@katre
Copy link
Collaborator Author

katre commented Oct 28, 2020

Downstream tests are running: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/1731

@katre
Copy link
Collaborator Author

katre commented Oct 28, 2020

Downstream tests have all passed, I'll start merging this internally.

@bazel-io bazel-io closed this in 775a979 Oct 28, 2020
@katre katre deleted the i12374-tcw-fix branch October 28, 2020 18:02
This was referenced Nov 2, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gregestren gregestren gregestren approved these changes

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Downstream projects broken by toolchain change

2 participants

@katre @gregestren