Remove //third_party/gflags #11564
Remove //third_party/gflags #11564
Conversation
It is unused. Completes work done in ttps://github.com/bazelbuild/pull/11564 RELNOTES: Delete third_party/py/gflags
|
This change is breaking downstream projects that depend on rules_docker. I think the problematic dependency comes from: |
|
Someone will have to update docker before the next major Bazel release. |
|
@aiuto Thanks! But until the issue is fixed in rules_docker and all downstream projects migrate to the new rules_docker version, our downstream will stay red. Do you think it makes sense to rollback this change first and roll-forward after the migration? |
|
We should let downstream projects stay red and potentially block new bazel releases on that. |
|
That will shadow other potential breakages that could have been caught by CI. |
|
I think that if people want to stay on Bazel at head, they have to be
prepared for breakages. This is the kind of change that no amount of
incompatible flags will smooth the transition. You either have to update
everything or you do not. Better to pull of the bandaid at head, where
there is no promise than defer this forever.
FWIW: rules_docker fixed this quickly,
bazelbuild/rules_docker#1533
…On Mon, Jun 15, 2020 at 10:45 AM Yun Peng ***@***.***> wrote:
That will shadow other potential breakages that could have been caught by
CI.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#11564 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXHHHABRRZWNPL2NO4UY5DRWYXYBANCNFSM4NYSIIVQ>
.
|
|
Cool! As long as people fixing the issue fast, I'm OK with it. I'm just afraid keeping the CI red will cause it hard to debug the causes of failures later. |
This fixes the missing gflags dependency introduced by bazelbuild/bazel#11564.
This fixes the missing gflags dependency introduced by bazelbuild/bazel#11564.
3 participants
It is unused.
See https://github.com/bazelbuild/bazel/pull/11201I