Anchor input fetches to source action id #11236
Conversation
Provide the specific action id via RequestMetadata which provided an action input artifact when using remote_download_minimal. This replaces the unattributable "fetch-remote-inputs" identifier populated for each input via a nested context.
src/main/java/com/google/devtools/build/lib/actions/FileArtifactValue.java
Outdated
Show resolved
Hide resolved
|
cc @ulfjack |
|
This seems to fail on import: https://buildkite.com/bazel/google-bazel-presubmit/builds/33753#_ I'll have a closer look tomorrow |
Just needs a merge update. Forthcoming. |
|
Ping on this, should be clean for merge. |
|
Sorry George, this needs some changes to internal code. I'll try to fix it next week. |
|
@werkt We are considering removing According to the REAPI spec,
The input prefetches are requested by local actions that depend on outputs of remote executed action (which is identified by the cc @tjgq |
actionId was added by #11236 to track download requests for input prefetches. However, according to the REAPI spec, action_id is > An identifier that ties multiple requests to the same action. For example, multiple requests to the CAS, Action Cache, and Execution API are used in order to compile foo.cc. The input prefetches are requested by local actions that depend on outputs of remote executed action (which is identified by the action_id). These requests are not part of generating action hence shouldn't be bound with the action_id. We could include ActionExecutionMetadata of the local action for the requests for the tracking purpose, but that desires another CL. PiperOrigin-RevId: 510430853 Change-Id: I8d64a4f7033320a394e02a2b11498f09a3d15310
actionId was added by bazelbuild#11236 to track download requests for input prefetches. However, according to the REAPI spec, action_id is > An identifier that ties multiple requests to the same action. For example, multiple requests to the CAS, Action Cache, and Execution API are used in order to compile foo.cc. The input prefetches are requested by local actions that depend on outputs of remote executed action (which is identified by the action_id). These requests are not part of generating action hence shouldn't be bound with the action_id. We could include ActionExecutionMetadata of the local action for the requests for the tracking purpose, but that desires another CL. PiperOrigin-RevId: 510430853 Change-Id: I8d64a4f7033320a394e02a2b11498f09a3d15310
actionId was added by #11236 to track download requests for input prefetches. However, according to the REAPI spec, action_id is > An identifier that ties multiple requests to the same action. For example, multiple requests to the CAS, Action Cache, and Execution API are used in order to compile foo.cc. The input prefetches are requested by local actions that depend on outputs of remote executed action (which is identified by the action_id). These requests are not part of generating action hence shouldn't be bound with the action_id. We could include ActionExecutionMetadata of the local action for the requests for the tracking purpose, but that desires another CL. PiperOrigin-RevId: 510430853 Change-Id: I8d64a4f7033320a394e02a2b11498f09a3d15310 Co-authored-by: Googler <[email protected]>
5 participants
Provide the specific action id via RequestMetadata which provided an
action input artifact when using remote_download_minimal. This replaces
the unattributable "fetch-remote-inputs" identifier populated for each
input via a nested context.