Python coverage: experimental first steps #10433
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add lcov_merger as an attribute to the py_test rule so that it does not immediately fall over - Add a small section to python_stub_template.txt to perform minimal setup for coverage integration I was able to get this to work manually by using a modified version of coverage.py, see: coveragepy/coveragepy#863 Note that the patch does not work out of the box. It's basically ~impossible to add integration tests until we get a working version of coverage.py, but this is the minimum change required in Bazel to get a basic working version.
bazel-io
pushed a commit
that referenced
this pull request
Jan 23, 2020
- Add lcov_merger as an attribute to the py_test rule so that it does not immediately fall over - Add a small section to python_stub_template.txt to perform minimal setup for coverage integration I was able to get this to work manually by using a modified version of coverage.py, see: coveragepy/coveragepy#863 Note that the patch does not work out of the box. It's basically ~impossible to add integration tests until we get a working version of coverage.py, but this is the minimum change required in Bazel to get a basic working version. Closes #10433. PiperOrigin-RevId: 291166690
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not immediately fall over
setup for coverage integration
I was able to get this to work manually by using a modified version of
coverage.py, see:
coveragepy/coveragepy#863
Note that the patch does not work out of the box.
It's basically ~impossible to add integration tests until we get a
working version of coverage.py, but this is the minimum change required
in Bazel to get a basic working version.