Skip to content

Fix grpc build on glibc 2.30#10290

Merged
bazel-io merged 1 commit intobazelbuild:masterfrom
davido:fix_grpc_on_gcc_9.2
Nov 29, 2019
Merged

Fix grpc build on glibc 2.30#10290
bazel-io merged 1 commit intobazelbuild:masterfrom
davido:fix_grpc_on_gcc_9.2

Conversation

@davido
Copy link
Copy Markdown
Contributor

@davido davido commented Nov 22, 2019

Closes #10285.

This applies this PR: [1] on grpc directory. To sync the grpc with the
latest release is outside of the scope of this CL.

[1] grpc/grpc#18950

@benjaminp
Copy link
Copy Markdown
Collaborator

To be clear the problem is not GCC 9 but rather glibc 2.30.

Closes bazelbuild#10285.

This applies this PR: [1] on grpc directory. To sync the grpc with the
latest release is outside of the scope of this CL.

[1] grpc/grpc#18950
@davido davido force-pushed the fix_grpc_on_gcc_9.2 branch from b8ecdac to f10cd50 Compare November 23, 2019 09:00
@davido davido changed the title Fix grpc build on gcc 9.2 Fix grpc build on glibc 2.30 Nov 23, 2019
@davido
Copy link
Copy Markdown
Contributor Author

davido commented Nov 23, 2019

To be clear the problem is not GCC 9 but rather glibc 2.30.

Commit message is changed correspondingly.

@dslomov dslomov added team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website untriaged labels Nov 25, 2019
@laszlocsomor laszlocsomor self-assigned this Nov 29, 2019
Copy link
Copy Markdown
Contributor

@laszlocsomor laszlocsomor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks David!

@bazel-io bazel-io merged commit f10cd50 into bazelbuild:master Nov 29, 2019
@davido
Copy link
Copy Markdown
Contributor Author

davido commented Nov 29, 2019

@laszlocsomor Thanks for merging!

@davido davido deleted the fix_grpc_on_gcc_9.2 branch November 29, 2019 11:37
@laszlocsomor
Copy link
Copy Markdown
Contributor

Re-pushed as 302acaa. (See #10285 (comment))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot build bazel@HEAD

6 participants